Feat/ nevermined #196
Merged
Feat/ nevermined #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
commented
Jan 8, 2024
packages/valory/skills/decision_maker_abci/behaviours/purchase_subscription.py
Outdated
Show resolved
Hide resolved
0xArdi
commented
Jan 8, 2024
packages/valory/skills/decision_maker_abci/behaviours/purchase_subscription.py
Outdated
Show resolved
Hide resolved
aaitor
reviewed
Jan 8, 2024
packages/valory/skills/decision_maker_abci/behaviours/purchase_subscription.py
Outdated
Show resolved
Hide resolved
0xArdi
commented
Jan 15, 2024
packages/valory/skills/decision_maker_abci/behaviours/purchase_subscription.py
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/packages.json # packages/valory/agents/trader/aea-config.yaml # packages/valory/services/trader/service.yaml # packages/valory/skills/decision_maker_abci/behaviours/round_behaviour.py # packages/valory/skills/decision_maker_abci/fsm_specification.yaml # packages/valory/skills/decision_maker_abci/rounds.py # packages/valory/skills/decision_maker_abci/skill.yaml # packages/valory/skills/trader_abci/fsm_specification.yaml # packages/valory/skills/trader_abci/skill.yaml # packages/valory/skills/tx_settlement_multiplexer_abci/skill.yaml
Adamantios
reviewed
Jan 19, 2024
| @property | ||
| def subscription_params(self) -> Dict[str, Any]: | ||
| """Get the subscription params.""" | ||
| return self.params.mech_to_subscription_params |
There was a problem hiding this comment.
Maybe add some sanity checks for the contents of these parameters when retrieving them (just in case). Their keys are being accessed unsafely below.
There was a problem hiding this comment.
This is one of them as well, its better to have them as you suggest as a dataclass or something similar.
Adamantios
reviewed
Jan 19, 2024
| @@ -192,6 +193,16 @@ models: | |||
| "openai-gpt-3.5-turbo", "openai-gpt-4", "stabilityai-stable-diffusion-v1-5", | |||
| "stabilityai-stable-diffusion-xl-beta-v2-2-2", "stabilityai-stable-diffusion-512-v2-1", | |||
| "stabilityai-stable-diffusion-768-v2-1"]} | |||
| use_nevermined: ${bool:true} | |||
| mech_to_subscription_params: ${list:[["base_url", "https://marketplace-api.gnosis.nevermined.app/api/v1/metadata/assets/ddo"], | |||
There was a problem hiding this comment.
Maybe mech_subscription_params?
There was a problem hiding this comment.
there are various fixes to be made to the subscription params, I suggest we handle them in a future version
Adamantios
approved these changes
Jan 19, 2024
0xArdi
commented
Jan 19, 2024
Comment on lines
+147
to
+151
| approval_params = {} | ||
| approval_params["token"] = self.payment_token | ||
| approval_params["spender"] = self.lock_payment_condition_address | ||
| approval_params["amount"] = self.price # type: ignore | ||
| return approval_params |
There was a problem hiding this comment.
can be inferred from the did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the trader with nevermined.