Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redeem amount #105

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix redeem amount #105

merged 2 commits into from
Oct 6, 2023

Conversation

Adamantios
Copy link
Collaborator

@Adamantios
fix: amount's calculation
e80f303 
The previous calculation was resulting in the number of conditional tokens instead of the amount in WEI.
@Adamantios
chore: run generators
de47218
@Adamantios Adamantios added the fix label Oct 6, 2023
@Adamantios Adamantios mentioned this pull request Oct 6, 2023
Merged
Adamantios
Adamantios commented Oct 6, 2023
View reviewed changes
packages/valory/skills/decision_maker_abci/redeem_info.py
amount = int(self.outcomeTokenMarginalPrice * self.outcomeTokensTraded)
amount = self.outcomeTokensTraded
Copy link
Collaborator Author

@Adamantios Adamantios Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous calculation resulted in the number of conditional tokens instead of the amount in WEI.

@Adamantios Adamantios merged commit 8f8bfbd into main Oct 6, 2023
6 checks passed
@Adamantios Adamantios deleted the fix/redeem-amount branch October 6, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xArdi 0xArdi 0xArdi approved these changes

@jmoreira-valory jmoreira-valory Awaiting requested review from jmoreira-valory

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adamantios @0xArdi