Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (CLI): Support custom components in publish and eject commands #758

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

OjusWiZard
Copy link
Member

@OjusWiZard OjusWiZard commented Sep 18, 2024

Proposed changes

Add support for custom type of components in the publish and eject subcommands of CLI

Fixes

closes valory-xyz/open-autonomy#2226
closes valory-xyz/open-autonomy#2237

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

PTAL @solarw @Adamantios

Copy link
Collaborator

@solarw solarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Adamantios Adamantios merged commit 3a0a6f3 into valory-xyz:main Sep 19, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please allow ejection of customs. Cusom component are not ejected with the command publish.
3 participants