Add support for dictionary overrides #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to fix the types of numeric keys as they can only be represented as strings in the json overrides.
0xArdi
reviewed
Aug 9, 2024
Comment on lines
+306
to
+318
| # this is a workaround to fix the type of numeric keys as they can only be represented as strs in the json overrides | ||
| for path in original_config: | ||
| path_as_str = tuple(map(str, path)) | ||
| if path_as_str in overrides and path not in overrides: | ||
| value = overrides[path_as_str] | ||
| del overrides[path_as_str] | ||
| up_to_last_key = data | ||
| for key in path_as_str[:-1]: | ||
| up_to_last_key = up_to_last_key[key] | ||
| del up_to_last_key[path_as_str[-1]] | ||
| overrides[path] = value | ||
| vals = reduce(lambda d, key: {key: d}, reversed(path), value) | ||
| update_nested_dict(data, vals) |
There was a problem hiding this comment.
Checks the type of the original format in the skill.yaml and uses this for the override. The overrides can only contain str keys, but they might be int, float, bool, etc.
|
The tests will need to be fixed. The new overrides format is demonstrated on valory-xyz/trader#311. Additionally, breaking changes will be necessary in the |
Adamantios
changed the title
jmoreira-valory
approved these changes
Aug 9, 2024
Adamantios
force-pushed
the
feat/override-dicts
branch
2 times, most recently
from
20dd077 to
abbe71f
Compare
Adamantios
force-pushed
the
feat/override-dicts
branch
from
abbe71f to
f95f465
Compare
Adamantios
changed the title
0xArdi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds support for dictionary overrides.
Fixes
n/a
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
n/a