-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise user image #669
Optimise user image #669
Conversation
- Use python 3.11 for deployments - Remove unwanted dependencies
FROM ubuntu:22.04 | ||
FROM python:3.11-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the minimal python image as base
RUN wget https://dl.google.com/go/go1.13.8.linux-amd64.tar.gz && \ | ||
tar -xzvf go1.13.8.linux-amd64.tar.gz -C /usr/local && \ | ||
export PATH=$PATH:/usr/local/go/bin && echo 'export PATH=$PATH:/usr/local/go/bin' >> ~/.bashrc && \ | ||
mkdir $HOME/go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required for agent runtime
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 371 371
Lines 29647 29647
=======================================
Hits 27370 27370
Misses 2277 2277
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
user-image/Dockerfile
Outdated
ENV DEBIAN_FRONTEND noninteractive | ||
ENV LC_ALL C.UTF-8 | ||
ENV LANG C.UTF-8 | ||
|
||
RUN apt update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angrybayblade better to join in one command with &&, so there will be no intermediate layers cosuming disk space.
so install and clean at the same time.
@@ -1,36 +1,19 @@ | |||
FROM ubuntu:22.04 | |||
FROM python:3.11-slim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool change!
we definitely need to pay more attention to the images quiality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.