Fix hardware wallet plugin protobuf incompatibility
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HW plugin tests can run in CI
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/bump-protocol-gen #667 +/- ##
=========================================================
Coverage ? 91.99%
=========================================================
Files ? 371
Lines ? 29539
Branches ? 0
=========================================================
Hits ? 27175
Misses ? 2364
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
angrybayblade
commented
Sep 22, 2023
Comment on lines
+137
to
+140
| @pytest.mark.skipif( | ||
| condition=(platform.system() == "Windows"), | ||
| reason="https://github.com/golang/go/issues/51007", | ||
| ) |
There was a problem hiding this comment.
I suggest we address this issue on a separate PR
angrybayblade
force-pushed
the
fix/hwi-plugin-protobuf-incompatibility
branch
from
328558d to
30a02c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Background -> We want to bump protobuf so that we can remove the forked dependencies, but bumping the protobuf to required version crashes the hardware wallet plugin. This PR adds a warning in the HWI plugin so the user is aware about how to fix this issue
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.