Merge pull request #766 from Divya-Solulab/fix/estimate-gas

fix: add from address in request
valory-xyz · Oct 28, 2024 · c282939 · c282939
2 parents bc0e6c5 + c6e5749
commit c282939
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/plugins/aea-ledger-ethereum/aea_ledger_ethereum/ethereum.py b/plugins/aea-ledger-ethereum/aea_ledger_ethereum/ethereum.py
@@ -1003,6 +1003,7 @@ def get_transfer_transaction(  # pylint: disable=arguments-differ
         if nonce is None:
             return transaction
         transaction = {
+            "from": sender_address,
             "nonce": nonce,
             "chainId": chain_id,
             "to": destination_address,

diff --git a/plugins/aea-ledger-ethereum/tests/test_ethereum.py b/plugins/aea-ledger-ethereum/tests/test_ethereum.py
@@ -422,7 +422,7 @@ def test_ethereum_api_get_transfer_transaction_2(*args):
         "max_fee_per_gas": 10,
     }
     with patch.object(ethereum_api.api.eth, "estimate_gas", return_value=1):
-        assert len(ethereum_api.get_transfer_transaction(**args)) == 8
+        assert len(ethereum_api.get_transfer_transaction(**args)) == 9
 
 
 @patch.object(EthereumApi, "_try_get_transaction_count", return_value=1)
@@ -441,7 +441,7 @@ def test_ethereum_api_get_transfer_transaction_3(*args):
         "max_fee_per_gas": 10,
     }
     with patch.object(ethereum_api.api.eth, "_max_priority_fee", return_value=1):
-        assert len(ethereum_api.get_transfer_transaction(**args)) == 8
+        assert len(ethereum_api.get_transfer_transaction(**args)) == 9
 
 
 def test_ethereum_api_get_deploy_transaction(ethereum_testnet_config):