style: changed date formatting and pr fixes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
truemiller
reviewed
Nov 29, 2024
Co-authored-by: Josh Miller <[email protected]>
truemiller
reviewed
Nov 29, 2024
Co-authored-by: Josh Miller <[email protected]>
truemiller
previously approved these changes
Nov 29, 2024
mohandast52
reviewed
Nov 29, 2024
components/Content/Article.jsx
Outdated
| @@ -22,20 +23,21 @@ const Article = ({ article, href, showReadTime, showDate }) => { | |||
|
|
|||
| const { title, datePublished, readTime } = article.attributes; | |||
There was a problem hiding this comment.
Suggested change
| const { title, datePublished, readTime } = article.attributes; | |
| const { title, datePublished: unFormattedDatePublished, readTime } = article.attributes; |
| month: 'long', | ||
| year: '2-digit', | ||
| }; | ||
| const formattedDate = newDate.toLocaleDateString('en-GB', options); |
There was a problem hiding this comment.
Suggested change
| const formattedDate = newDate.toLocaleDateString('en-GB', options); | |
| const formattedDate = newDate.toLocaleDateString('en-US', options); |
as we use American english, afaik the order of the day and month is different
There was a problem hiding this comment.
Mmm I think GB works better as it displays it as 11-Nov-24 instead of Nov-28,-24
There was a problem hiding this comment.
the replace call below makes this weird
would remove the - replacement, and set as en-US, not 100% on product preference, but US > GB in market share
- dates tend~ to be for numeric dates
minor either way, clock still ticks haha
truemiller
approved these changes
Nov 29, 2024
mohandast52
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Screenshots/Recordings
Before:
After:
