Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show needs funds alert, fix debug info #592

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

Tanya-atatakai
Copy link
Collaborator

Proposed changes

reenable needs funds alert
fix duplicated master safes on debug page

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@@ -71,7 +71,7 @@ const useStakingRewardsDetails = () => {
chainId: currentChainId,
});

if (!response) return;
if (!response) return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubt: oh, why just return wasn't working? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tanstack complains when returning undefined :( there are a lot of errors in console

@Tanya-atatakai Tanya-atatakai merged commit 005cd99 into fix/meme-staging Dec 15, 2024
3 of 4 checks passed
@Tanya-atatakai Tanya-atatakai deleted the tanya/fixes branch December 15, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants