Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: navigate to switch if agent switch if no master safe #582

Open
wants to merge 5 commits into
base: feature/agent-memeooorr
Choose a base branch
from

Conversation

mohandast52
Copy link
Collaborator

Proposed changes

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the bug Something isn't working label Dec 13, 2024
@mohandast52 mohandast52 self-assigned this Dec 13, 2024
// If no service is created for the selected agent
if (!isServiceCreatedForAgent) {
window.console.log(
`No master safe for chain ${selectedServiceOrAgentChainId}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`No master safe for chain ${selectedServiceOrAgentChainId}`,
`No service created for chain ${selectedServiceOrAgentChainId}`,

?

@mohandast52 mohandast52 marked this pull request as ready for review December 13, 2024 15:43
masterSafe?.address,
selectedServiceOrAgentChainId,
wallets?.length,
selectedService?.name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure if we should have it here, and maybe should also check isServicesFetched
but can simply ask everyone to wait for some time before logging in, too complex to figure this out on the fly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants