feat: add service template #576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
requested review from
mohandast52,
truemiller and
jmoreira-valory
Tanya-atatakai
force-pushed
the
feature/modius
branch
from
d877ae9 to
d669d62
Compare
mohandast52
approved these changes
Dec 12, 2024
truemiller
reviewed
Dec 12, 2024
.env.example
Outdated
| BASE_RPC= | ||
| MODE_RPC= |
There was a problem hiding this comment.
do we have mode rpc gateway yet @Tanya-atatakai?
There was a problem hiding this comment.
afaik we don't and should use the public one
| }, | ||
| }, | ||
| }, | ||
| env_variables: { |
There was a problem hiding this comment.
Missing RPC variables (computed)
There was a problem hiding this comment.
have added MODE_LEDGER_RPC but unsure if this is the one.
Comment on lines
357
to
361
| SELECTED_STRATEGIES: { | ||
| name: 'Selected strategies', | ||
| description: '', | ||
| value: '', | ||
| provision_type: EnvProvisionType.COMPUTED, |
There was a problem hiding this comment.
Same, this can possibly be a fixed value.
There was a problem hiding this comment.
have updated as I understood it (using this https://github.com/valory-xyz/modius-quickstart/blob/main/run_service.py#L403)
Tanya-atatakai
force-pushed
the
tanya/service-template
branch
from
214eee7 to
b28c680
Compare
Tanya-atatakai
force-pushed
the
feature/modius
branch
from
d669d62 to
978c2b8
Compare
Tanya-atatakai
force-pushed
the
tanya/service-template
branch
from
b28c680 to
218a66d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add service template for Modius
Based on:
https://github.com/valory-xyz/modius-quickstart/blob/main/run_service.py#L434
https://github.com/valory-xyz/modius-quickstart/blob/main/run_service.py#L899
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply