feat: add modius configs #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truemiller
reviewed
Dec 11, 2024
| @@ -19,6 +19,7 @@ const safeChainPrefix = { | |||
| [EvmChainId.Base]: 'base', | |||
| [EvmChainId.Optimism]: 'oeth', | |||
| [EvmChainId.Gnosis]: 'gno', | |||
| [EvmChainId.Mode]: 'mode', // TODO: Modius - the above link doesn't have Mode, so the prefix is a guess | |||
There was a problem hiding this comment.
bit of a worry that safe.global doesn't support mode..
truemiller
reviewed
Dec 11, 2024
mohandast52
approved these changes
Dec 11, 2024
Comment on lines
+133
to
+141
| const multicallResponse = await multicallProvider.all(contractCalls); | ||
| const [rewardsPerSecond, livenessPeriod, tsCheckpoint] = multicallResponse; | ||
| const nowInSeconds = Math.floor(Date.now() / 1000); | ||
|
|
||
| return Math.max( | ||
| rewardsPerSecond * livenessPeriod, // expected rewards | ||
| rewardsPerSecond * (nowInSeconds - tsCheckpoint), // incase of late checkpoint | ||
| ); | ||
| }; |
There was a problem hiding this comment.
This seems repetitive now (also few other logics). How about creating a reusable function within the StakedAgentService class that takes arguments and performs the calculation for us?
There was a problem hiding this comment.
will update or not based on our discussion on slack
| // Rewards per work period | ||
| const rewardsPerWorkPeriod = | ||
| Number(formatEther(rewardsPerSecond as bigint)) * | ||
| livenessPeriod.toNumber(); |
Co-authored-by: Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add configs for modius.
Sources used for finding addresses:
https://govern.olas.network/contracts/0x000000000000000000000000534c0a05b6d4d28d5f3630d6d74857b253cf8332
https://github.com/valory-xyz/autonolas-registries/blob/main/docs/configuration.json#L380
https://github.com/valory-xyz/autonolas-governance/blob/main/docs/olas_bridging.md
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply