Update services before starting #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohandast52
approved these changes
Dec 10, 2024
Tanya-atatakai
approved these changes
Dec 11, 2024
| try { | ||
| const serviceToStart = service ?? middlewareServiceResponse; | ||
| await ServicesService.startService(serviceToStart!.service_config_id); | ||
| if (service && !createServiceResponse) { |
There was a problem hiding this comment.
does create also run the service now? so we shouldn't start manually?
There was a problem hiding this comment.
good catch thanks, should be the other way round i think 😓
| // Update if service already exists and template hash has changed | ||
| if (!createServiceResponse && service) { | ||
| try { | ||
| if (service.hash !== serviceTemplate.hash) { |
There was a problem hiding this comment.
is this needed to support previous versions?
There was a problem hiding this comment.
correct, there were issues when users migrated from legacy staging to the latest; the template hashes had updated but did not support the new environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply