Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: start button stuck on loading #550

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix: start button stuck on loading #550

merged 3 commits into from
Dec 9, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Dec 6, 2024 •
edited
Loading

Proposed changes

  • Start agent button should not stuck on loading
Start.agent.mov

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 added the bug Something isn't working label Dec 6, 2024
@mohandast52 mohandast52 self-assigned this Dec 6, 2024
@mohandast52 mohandast52 marked this pull request as ready for review December 6, 2024 16:17
@mohandast52 mohandast52 merged commit c0a8bc6 into mohan/dynamic-explorer-url Dec 9, 2024
5 checks passed
@mohandast52 mohandast52 deleted the mohan/fix-start-btn-loading branch December 9, 2024 07:47
mohandast52 added a commit that referenced this pull request Dec 9, 2024
@mohandast52
feat: (Settings page) dynamic explorer url (#549)
82b707b 
* feat: update SettingsPage to use selected service for dynamic backup address link

* feat: refactor AddressLink component and integrate it into SettingsPage for improved address handling

* feat: add SWAP_BASE_URL constant and update SWAP_URL_BY_EVM_CHAIN to include Base chain

* feat: update swap URLs to use new SWAP_BASE_URL and improve code organization

* fix: start button stuck on loading (#550)

* feat: update Skeleton component in SettingsPage for improved loading state

* refactor: simplify service loading state management in AgentButton and StakingContractDetailsProvider

* fix: add missing braces for conditional checks in AgentNotRunningButton and StakingRewardsThisEpoch components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truemiller truemiller truemiller approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

Assignees

@mohandast52 mohandast52

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohandast52 @Tanya-atatakai @truemiller