feat: add isEligibleForRewards logic, some fixes around loading states #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
commented
Dec 6, 2024
| @@ -239,8 +238,8 @@ export const ServicesProvider = ({ children }: PropsWithChildren) => { | |||
| services, | |||
| serviceWallets, | |||
| isError, | |||
| isFetched: isServicesFetched, | |||
| isLoading, | |||
| isFetched: !isServicesLoading, | |||
There was a problem hiding this comment.
we need to change isFetched to isLoading, there are still places where the buttons stuck in infinite loading b/c service is not created and isFetched is always false due to the query having enabled=false
mohandast52
approved these changes
Dec 6, 2024
| @@ -239,8 +238,8 @@ export const ServicesProvider = ({ children }: PropsWithChildren) => { | |||
| services, | |||
| serviceWallets, | |||
| isError, | |||
| isFetched: isServicesFetched, | |||
| isLoading, | |||
| isFetched: !isServicesLoading, | |||
truemiller
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply