Fix duplicte keys creation #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truemiller
approved these changes
Jul 11, 2024
0xArdi
approved these changes
Jul 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes key management as follows.
Previously, keys for a service were freshly created, but only stored once the service mint-activation-registration process was successful on-chain.
If that proces broke somewhere, the middleware would create new fresh keys for the service agents, which would lead to duplicate keys on the .operate/keys folder.
The current approach creates fresh keys when the Service object is created (not loaded from an existing file). Therefore, keys are always stored in the config.json file upon service creation. This will ensure that no duplicate keys are created if the on-chain process fails.
Note: this uncovered an issue with the front-end #227