Fix mech requests criteria for rewards eligibility #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohandast52
reviewed
Jun 17, 2024
…onsole.log statements
…for calculating nowInSeconds
truemiller
commented
Jun 19, 2024
frontend/service/Autonolas.ts
Outdated
| @@ -134,16 +140,22 @@ const getAgentStakingRewardsInfo = async ({ | |||
| const getAvailableRewardsForEpoch = async (): Promise<number | undefined> => { | |||
| const contractCalls = [ | |||
| serviceStakingTokenMechUsageContract.rewardsPerSecond(), | |||
| serviceStakingTokenMechUsageContract.livenessPeriod(), | |||
| serviceStakingTokenMechUsageContract.livenessPeriod(), // epoch length? | |||
| serviceStakingTokenMechUsageContract.tsCheckpoint(), // last checkpoint timestamp? | |||
There was a problem hiding this comment.
i'm assuming the last checkpoint timestamp is roughly the same as the start of the current epoch?
There was a problem hiding this comment.
livenessPeriod is a constant for each staking program. It's the minimum epoch lenght (minimum call between checkpoints)
tsCheckpoint is the latest executed checkpoint - start of a new epoch.
jmoreira-valory
approved these changes
Jun 19, 2024
truemiller
commented
Jun 21, 2024
truemiller
commented
Jun 21, 2024
oaksprout
approved these changes
Jun 21, 2024
mohandast52
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are no contract errors thrown with the updated changes @oaksprout unsure if this is enough to merge to main, but the formula makes sense, and has been approved thus far.