feat: first with boilerplate #1
Conversation
There was a problem hiding this comment.
Looks good overall, but few comments regarding frontend preferences and suggestions:
- Would be great to prettify files (format document) - for consistent tabbing and spacing.
- Let's avoid using the "any" type; we have eslint rule
"@typescript-eslint/no-explicit-any". - Noticed eslint errors; it would be great to address them.
- Consider utilizing
antdcomponents such as Typography (title, paragraph, text), Image, etc to be consistent
frontend/electron/main.js
Outdated
| win.setMenuBarVisibility(false); | ||
|
|
||
|
|
||
| win.loadURL("http://localhost:3000"); |
There was a problem hiding this comment.
doubt: would it still work if 3000 port is already taken?
frontend/context/AgentsProvider.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| if (error) return console.log(error); | ||
| setAgents(data); |
There was a problem hiding this comment.
Is it necessary for us to store this data? Since we are already fetching it using useSWR, it seems like we might be duplicating it. What do you think?
…olas-operate-app into feature/frontend-boilerplate
components/Layout/Navbar/Navbar.tsx
Outdated
There was a problem hiding this comment.
Our path naming convention elsewhere is usually Navbar/index.jsx, but I have thought for a while like this Navbar/Navbar.tsx is easier to read when searching. Would suggest we move towards this. Thoughts @mohandast52?
There was a problem hiding this comment.
yes, agreed 💯 This structure is far easier to navigate compared to a bunch of index files.
first commit, with boilerplate code for nextjs/electron app