Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemini request mech tool #228

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Conversation

victorpolisetty
Copy link
Contributor

@victorpolisetty victorpolisetty commented May 12, 2024

Proposed changes

Adding Google Gemini as a mech tool. To be utilized as an alternative A.I. LLM tool to answer questions.

Would appreciate review as this is my first mech tool attempt. @0xArdi @dvilelaf

Fixes

NA.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

Currently only supporting single question answers (no memory) and no picture to text models (vision-pro models).

@dvilelaf dvilelaf requested a review from 0xArdi May 16, 2024 08:00
@victorpolisetty victorpolisetty requested a review from dvilelaf May 20, 2024 17:25
@0xArdi
Copy link
Collaborator

0xArdi commented May 22, 2024

@victorpolisetty looks good! We need to add a gemini key to our CI so you can add tests to make sure everything is OK. I will ping here once we do that.

@victorpolisetty
Copy link
Contributor Author

victorpolisetty commented May 23, 2024

@victorpolisetty looks good! We need to add a gemini key to our CI so you can add tests to make sure everything is OK. I will ping here once we do that.

Awesome!

@0xArdi
Copy link
Collaborator

0xArdi commented May 24, 2024

@victorpolisetty can you resolve the merge conflicts?

@victorpolisetty
Copy link
Contributor Author

@victorpolisetty can you resolve the merge conflicts?

Thanks for the review. Will take a look this weekend :)

@victorpolisetty
Copy link
Contributor Author

@0xArdi Fixed merge conflicts

@victorpolisetty
Copy link
Contributor Author

@0xArdi Added deps. Please advise on further steps.

@0xArdi 0xArdi merged commit 10fbda7 into valory-xyz:main Jun 17, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants