Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bagel mech tool #226

Closed
wants to merge 2 commits into from
Closed

Conversation

BidhanRoy
Copy link

Proposed changes

Adding Bagel as a mech tool. To be utilized as a resource to generate better inferences via enriched prompts to LLMs.

Fixes

NA.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

ids=[f"doc_{len(cluster)}"]
)

return "Document added successfully.", None, None, None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that this is what will get returned as a response to this request. Is this what was intended?
Is this tool meant to be used in combination with some other tool, or how are you imaging it?

Comment on lines +73 to +77
return {
"documents": documents,
"distances": distances,
"metadatas": metadatas
}, None, None, None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First element in the returned value is expected to be string.

# -*- coding: utf-8 -*-
# ------------------------------------------------------------------------------
#
# Copyright 2023-2024 Valory AG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue, but this is technically expected to be 2024 only. Same for the file above.

@0xArdi
Copy link
Collaborator

0xArdi commented May 22, 2024

@BidhanRoy thanks! Changes overall look good. Ideally, we add a bagel key to our CI so we can test here if everything is OK.


from typing import Any, Dict, Optional, Tuple

import bagelml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be added to project deps

@0xArdi
Copy link
Collaborator

0xArdi commented Jun 21, 2024

@BidhanRoy Would be good to addresses the comments above, so we can merge.

@0xArdi
Copy link
Collaborator

0xArdi commented Nov 22, 2024

We are in the process of migrating the project to a new location.
As part of the transition, we are closing your open pull request.

  • No new tool PRs will be merged here.
  • This repo will only contain a bare minimum set of the dependencies. This repo will serve as a base repo for people looking to develop their own mechs and follow this as an example in the future.
  • We invite you to go through our quickstart on how to setup your mech and tools.

Thank you for your contributions!

@0xArdi 0xArdi closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants