-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bagel mech tool #226
Bagel mech tool #226
Conversation
ids=[f"doc_{len(cluster)}"] | ||
) | ||
|
||
return "Document added successfully.", None, None, None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that this is what will get returned as a response to this request. Is this what was intended?
Is this tool meant to be used in combination with some other tool, or how are you imaging it?
return { | ||
"documents": documents, | ||
"distances": distances, | ||
"metadatas": metadatas | ||
}, None, None, None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First element in the returned value is expected to be string.
# -*- coding: utf-8 -*- | ||
# ------------------------------------------------------------------------------ | ||
# | ||
# Copyright 2023-2024 Valory AG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small issue, but this is technically expected to be 2024 only. Same for the file above.
@BidhanRoy thanks! Changes overall look good. Ideally, we add a bagel key to our CI so we can test here if everything is OK. |
|
||
from typing import Any, Dict, Optional, Tuple | ||
|
||
import bagelml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be added to project deps
@BidhanRoy Would be good to addresses the comments above, so we can merge. |
We are in the process of migrating the project to a new location.
Thank you for your contributions! |
Proposed changes
Adding Bagel as a mech tool. To be utilized as a resource to generate better inferences via enriched prompts to LLMs.
Fixes
NA.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...