Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tomte a dev dependency #222

Merged
merged 1 commit into from
May 22, 2024

Conversation

evangriffiths
Copy link
Contributor

@evangriffiths evangriffiths commented Apr 29, 2024

Proposed changes

tomte doesn't need to be a core dependency of this repo. Move it to a dev dependency to avoid unnecessary dependency restrictions on dependant projects.

Types of changes

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@0xArdi 0xArdi merged commit f0366ca into valory-xyz:main May 22, 2024
2 of 5 checks passed
@0xArdi
Copy link
Collaborator

0xArdi commented May 22, 2024

Thanks @evangriffiths !

@evangriffiths
Copy link
Contributor Author

Thanks for the merge @0xArdi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants