fix: funds splitting logic #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xArdi
commented
Apr 16, 2024
| @@ -529,7 +541,7 @@ def _accumulate_reqs_by_operator( | |||
| agent_instances = list(reqs_by_agent.keys()) | |||
| contract_api_msg = yield from self.get_contract_api_response( | |||
| performative=ContractApiMessage.Performative.GET_STATE, # type: ignore | |||
| contract_address=self.params.agent_registry_address, | |||
| contract_address=self.params.service_registry_address, | |||
There was a problem hiding this comment.
not sure how this was ever working with this issue
There was a problem hiding this comment.
Remember to set the env var when deploying, because the default is zero address:
0xArdi
commented
Apr 16, 2024
Comment on lines
+519
to
+528
| # in case an agent maps to an operator that is the zero address | ||
| # we need to remove it from the list of addresses that will receive funds | ||
| # this can happen in case of changing agent instances in the service registry | ||
| # old agent instances will map to the zero address, because they are still part of | ||
| # usage history | ||
| invalid_operator_reqs = accumulated_reqs_by_operator.pop(ZERO_ADDRESS, 0) | ||
|
|
||
| # remove the invalid operator reqs from the total reqs, | ||
| # so that we share 100% of the funds among the valid operators | ||
| total_reqs -= invalid_operator_reqs |
There was a problem hiding this comment.
this is critical, otherwise funds would be transferred to zero address
dvilelaf
approved these changes
Apr 16, 2024
Adamantios
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the funds splitting logic.