Benchmark and deploy mech tools #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evangriffiths
changed the title
evangriffiths
changed the title
evangriffiths
commented
Feb 14, 2024
| @@ -1138,7 +1139,7 @@ def run(**kwargs) -> Tuple[str, Optional[str], Optional[Dict[str, Any]], Any]: | |||
| engine = TOOL_TO_ENGINE[tool] | |||
|
|
|||
| # Extract the event question from the prompt | |||
| event_question = re.search(r"\"(.+?)\"", prompt).group(1) | |||
There was a problem hiding this comment.
Regex search often returns None, causing exception
evangriffiths
commented
Feb 14, 2024
| @@ -303,7 +304,6 @@ def fetch_additional_information( | |||
| json_data["queries"], | |||
| api_key=google_api_key, | |||
| engine=google_engine, | |||
| num_urls=num_urls, | |||
evangriffiths
commented
Feb 14, 2024
| @@ -60,7 +60,8 @@ def count_tokens(text: str, model: str) -> int: | |||
|
|
|||
|
|
|||
| NUM_URLS_EXTRACT = 5 | |||
| DEFAULT_NUM_WORDS: Dict[str, Optional[int]] = defaultdict(lambda: 300) | |||
evangriffiths
commented
Feb 14, 2024
| @@ -202,7 +203,7 @@ def get_urls_from_queries(queries: List[str], api_key: str, engine: str) -> List | |||
| query=query, | |||
| api_key=api_key, | |||
| engine=engine, | |||
| num=3, # Number of returned results | |||
There was a problem hiding this comment.
3 or NUM_URLS_EXTRACT==5? Hmm, let's use global var
|
Oops, base branch was meant to be my fork! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PMAT dependency and add scripts for benchmarking and deploying mech tools