Skip to content

Commit

Permalink
feat: enable generate all protocol check
Browse files Browse the repository at this point in the history
  • Loading branch information
angrybayblade committed Jun 13, 2023
1 parent affaf5f commit e06ea03
Show file tree
Hide file tree
Showing 4 changed files with 66 additions and 64 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/common_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ jobs:
# Install `mdspell` for spelling checks
sudo npm install -g markdown-spellcheck
make protolint_install
# Temporary skip
# - name: Check generate protocols
# run: tox -e check-generate-all-protocols
- name: Check generate protocols
run: tox -e check-generate-all-protocols
- name: Security checks
run: tomte check-security
- name: Check packages
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,6 @@ fix-abci-app-specs:
autonomy analyse fsm-specs --update --app-class MechAbciApp --package packages/valory/skills/mech_abci
autonomy analyse fsm-specs --update --app-class TaskExecutionAbciApp --package packages/valory/skills/task_execution_abci
echo "Successfully validated abcis!"

protolint_install:
GO111MODULE=on GOPATH=~/go go get -u -v github.com/yoheimuta/protolint/cmd/[email protected]
62 changes: 1 addition & 61 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 59 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
[flake8]
paths=packages
exclude=.md,
*_pb2.py,
*_pb2_grpc.py,
custom_types.py,

max-line-length = 88
select = B,C,D,E,F,I,W,
ignore = E203,E501,W503,D202,B014,D400,D401,DAR
application-import-names = packages,tests,scripts

# ignore as too restrictive for our needs:
# D400: First line should end with a period
# D401: First line should be in imperative mood
# E501: https://www.flake8rules.com/rules/E501.html (Line too long)
# E203: https://www.flake8rules.com/rules/E203.html (Whitespace)
# W503: https://www.flake8rules.com/rules/W503.html (Line break)
# D202: blank lines
# B014: redundant exception

[isort]
# for black compatibility
multi_line_output=3
include_trailing_comma=True
force_grid_wrap=0
use_parentheses=True
ensure_newline_before_comments = True
line_length=88
# custom configurations
order_by_type=False
case_sensitive=True
lines_after_imports=2
skip=packages/valory/skills/abstract_round_abci/test_tools/integration.py,packages/valory/skills/transaction_settlement_abci/test_tools/integration.py,
skip_glob =
known_first_party=autonomy
known_packages=packages
known_local_folder=tests
sections=FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,PACKAGES,LOCALFOLDER

[mypy]
python_version = 3.8
strict_optional = True
exclude=(.*_pb2|.*custom_types)

# Before adding a module here, make sure it does not support type hints
# Per-module options for aea dir:

[mypy-packages.valory.*]
ignore_errors=True

[mypy-packages.open_aea.*]
ignore_errors=True

[darglint]
docstring_style=sphinx
strictness=short
ignore_regex=async_act
ignore=DAR401

0 comments on commit e06ea03

Please sign in to comment.