Market approval fix #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
reviewed
Jan 3, 2024
There was a problem hiding this comment.
I recommend converting all these new logs to the debug level.
There was a problem hiding this comment.
Thanks, will be considered for future improvement. The logs of this part are not very heavyweight now (only a few variables are displayed, and raw output of LLM and API calls have been suppressed in this part).
Adamantios
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes market approval logic.
Now it examines all closing dates between
nowandnow + approve_market_event_days_offsetand ensures that there aremarkets_to_approve_per_dayon each closing day in that interval.