fix: misc. issues with closing #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
approved these changes
Dec 22, 2023
| state = self.synchronized_data.update( | ||
| synced_data = cast(SynchronizedData, self.synchronized_data) | ||
|
|
||
| # Fix to ensure properties are present on the SynchronizedData |
There was a problem hiding this comment.
Isn't this already on main?
| initial_states: Set[AppState] = { | ||
| CollectRandomnessRound, | ||
| PostTransactionRound, | ||
| CloseMarketsRound, |
There was a problem hiding this comment.
the way it was previously wired, CloseMarkets can end up not being called. Now it is the first behaviour that is called after registration, in order to do that it must be a initial state.
Adamantios
approved these changes
Dec 22, 2023
jmoreira-valory
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes multiple issues introduced with
market_closing.