Feat/close markets #77
Conversation
# Conflicts: # packages/packages.json # packages/valory/agents/market_maker/aea-config.yaml # packages/valory/services/market_maker/service.yaml # packages/valory/skills/market_creation_manager_abci/payloads.py # packages/valory/skills/market_creation_manager_abci/skill.yaml # packages/valory/skills/market_maker_abci/skill.yaml
| NO_TX = "no_tx" | ||
| ERROR_PAYLOAD = "error" | ||
|
|
||
| def end_block(self) -> Optional[Tuple[BaseSynchronizedData, Enum]]: |
There was a problem hiding this comment.
Is it possible to call super() here instead of re-write the method?
There was a problem hiding this comment.
i dont think so, we have custom logic
There was a problem hiding this comment.
Please @Adamantios take a look.
There was a problem hiding this comment.
It's possible to convert it to something like the following:
There was a problem hiding this comment.
It would just mean moving the logic from here to the base class. Which i don't see what the point is in doing that right now, we are not reusing this.
| prompt_template = self.params.market_identification_prompt | ||
| prompt_values = { | ||
| "input_news": input_news, | ||
| "topics": topics, | ||
| "event_day": event_day.strftime("%-d %B %Y"), |
There was a problem hiding this comment.
Why delete "topics" ?? This is required in the prompt on self.params.market_identification_prompt
There was a problem hiding this comment.
On accident, will revert
| continue | ||
| question_to_answer[question["question"]["id"]] = answer | ||
|
|
||
| if len(question_to_answer) == self.params.num_questions_to_close: |
There was a problem hiding this comment.
What is this doing ?
There was a problem hiding this comment.
Limiting the number of questions we answer at once.
There was a problem hiding this comment.
Ok, the name is a bit misleading, i thougt it was the total number of questions to answer overall.
There was a problem hiding this comment.
I'll rename to questions_to_close_batch_size, ok?
This PR adds support for autonomously closing the markets.