refactor and test: addressing audit issue 16 #144
Merged
Annotations
17 warnings
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v3, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
contracts/DeploymentFactory.sol#L4
global import of path @openzeppelin/contracts/utils/Create2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/DeploymentFactory.sol#L5
global import of path ./OLAS.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/DeploymentFactory.sol#L6
global import of path ./veOLAS.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/OLAS.sol#L4
global import of path ../lib/solmate/src/tokens/ERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/OLAS.sol#L28
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
contracts/Timelock.sol#L4
global import of path @openzeppelin/contracts/governance/TimelockController.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/VoteWeighting.sol#L162
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
contracts/buOLAS.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/buOLAS.sol#L5
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
contracts/buOLAS.sol#L6
global import of path ./interfaces/IErrors.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
scripts/deployment/bridges/solana/test/polygon/deploy_00_mock_timelock.js#L26
'provider' is assigned a value but never used
|
|
scripts/deployment/bridges/solana/test/sepolia/deploy_00_mock_timelock.js#L12
'provider' is assigned a value but never used
|
|
test/Deployment.js#L38
'deploymentAddress' is defined but never used
|
|
test/Deployment.js#L43
'deploymentAddress' is defined but never used
|
|
test/Deployment.js#L43
'olasAddress' is defined but never used
|
This job succeeded
Loading