Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sync-on-hash #123

Merged
merged 32 commits into from
Feb 5, 2024
Merged

Fix/sync-on-hash #123

merged 32 commits into from
Feb 5, 2024

Conversation

dvilelaf
Copy link
Collaborator

@dvilelaf dvilelaf commented Feb 1, 2024

Proposed changes

The db size has grown a lot on Contribute. This PR implements changes so agents sync on the db hash instead of the db data.

Fixes

n/a

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments

n/a

Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to use the remote IPFS at some point to enable the agents to sync the data among them. Otherwise, if one stays back, then it cannot ever rejoin.

You could use some structure for the db instead of a dict in the future.

Try to avoid unnecessarily overriding the rounds' end_block in the future. It makes the code hard to read and maintain.

Try to split PRs in the future as it is hard to review huge PRs like this one which change too many things at once.

@dvilelaf
Copy link
Collaborator Author

dvilelaf commented Feb 5, 2024

Let's open an issue to use the remote IPFS at some point to enable the agents to sync the data among them. Otherwise, if one stays back, then it cannot ever rejoin.

You could use some structure for the db instead of a dict in the future.

Try to avoid unnecessarily overriding the rounds' end_block in the future. It makes the code hard to read and maintain.

Try to split PRs in the future as it is hard to review huge PRs like this one which change too many things at once.

#126

@dvilelaf dvilelaf merged commit 87af985 into main Feb 5, 2024
19 checks passed
@dvilelaf dvilelaf deleted the fix/db branch February 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants