-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/sync-on-hash #123
Fix/sync-on-hash #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open an issue to use the remote IPFS at some point to enable the agents to sync the data among them. Otherwise, if one stays back, then it cannot ever rejoin.
You could use some structure for the db instead of a dict
in the future.
Try to avoid unnecessarily overriding the rounds' end_block
in the future. It makes the code hard to read and maintain.
Try to split PRs in the future as it is hard to review huge PRs like this one which change too many things at once.
|
Proposed changes
The db size has grown a lot on Contribute. This PR implements changes so agents sync on the db hash instead of the db data.
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.Further comments
n/a