feat(earn): cross chain swap and deposit changes on deposit entrypoint #6390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6390 +/- ##
==========================================
- Coverage 89.05% 89.05% -0.01%
==========================================
Files 735 735
Lines 31350 31368 +18
Branches 5820 5529 -291
==========================================
+ Hits 27919 27934 +15
- Misses 3237 3388 +151
+ Partials 194 46 -148
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
reviewed
Dec 31, 2024
locales/base/translation.json
Outdated
| "beforeYouCanDepositTitle": "Before you can deposit...", | ||
| "beforeYouCanDepositDescription": "You’ll need to add one of the pool tokens. Once added, you’ll need to return to complete your pool deposit.", | ||
| "beforeYouCanDepositDescriptionV1_101": "You’ll need to add {{tokenSymbol}} on {{tokenNetwork}}. Once added, you’ll need to return to complete your pool deposit.", | ||
| "action": { | ||
| "swapAndDeposit": "Swap & Deposit", | ||
| "swapAndDepositDescription": "Choose any token on {{tokenNetwork}}. We’ll swap and deposit it simultaneously for you.", | ||
| "swapAndDepositAllTokensDescription": "Choose any token\u2014we’ll swap and deposit it simultaneously for you.", |
There was a problem hiding this comment.
Why would we use \u2014 instead of —? I couldn't find another instance of unicode characters in the translation files.
There was a problem hiding this comment.
I thought it was copying the regular dash originally, - and — looked the same in the monospace font from a quick look 😄 . I updated it now to directly use the dash
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
jh2oman
reviewed
Jan 2, 2025
| StatsigFeatureGates.ALLOW_CROSS_CHAIN_SWAP_AND_DEPOSIT | ||
| ) | ||
|
|
||
| const { canSwapDeposit, showCrossChainSwap, showSwap, showAdd, showAddMore, showTransfer } = |
jh2oman
approved these changes
Jan 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
#6390) ### Description [Figma](https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Earn?node-id=8418-38843&t=JGtN2YLsGFMZeYcS-0) ### Test plan Unit tests, manual Updated swap & deposit option and description: <img src="https://github.com/user-attachments/assets/1f376276-c557-49a8-bdc2-6e9b37ae0346" width="250" /> <img src="https://github.com/user-attachments/assets/aabee4fa-bfd1-4ff6-a6f9-6605c396cff0" width="250" /> <img src="https://github.com/user-attachments/assets/98316847-0f83-4c2b-bf4b-ad51b0c71edd" width="250" /> ### Related issues - Part of ACT-1507 ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Figma
Test plan
Unit tests, manual
Updated swap & deposit option and description:
Related issues
Backwards compatibility
Yes
Network scalability
N/A