Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): support cross chain swap and deposit #6382

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Dec 18, 2024

Description

Support cross chain swap and deposit behind a statsig feature gate. UI changes not in scope for this PR and will be in a follow up (showing cross chain fees, updating bottom sheet to no longer show cross chain swap as a separate option, showing cross chain fee error if not enough for gas)

Test plan

Manually tested and ensured

  • Right tokens show up in the expected order (same chain first, then cross chain, by balance within each section)
  • Tx submitted and executed sucessfully
cross-chain-swap-deposit.mp4

Source chain tx
Destination chain tx
Alexar scan

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (1421494) to head (623e668).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6382   +/-   ##
=======================================
  Coverage   89.03%   89.04%           
=======================================
  Files         735      735           
  Lines       31327    31345   +18     
  Branches     5812     5821    +9     
=======================================
+ Hits        27892    27910   +18     
+ Misses       3242     3241    -1     
- Partials      193      194    +1     
Files with missing lines Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/earn/EarnDepositBottomSheet.tsx 98.78% <100.00%> (+0.01%) ⬆️
src/earn/EarnEnterAmount.tsx 94.98% <100.00%> (+1.58%) ⬆️
src/earn/prepareTransactions.ts 100.00% <ø> (ø)
src/earn/saga.ts 95.76% <100.00%> (+0.11%) ⬆️
src/statsig/types.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1421494...623e668. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 43ac959 Dec 20, 2024
15 checks passed
@satish-ravi satish-ravi deleted the satish/act-1507 branch December 20, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants