Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qr-scanner): align times icon #6226

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Nov 13, 2024

Description

Align the times icon with other times icons.

iOS Settings Before iOS QR Code Before iOS Settings After iOS QR Code After
Android Settings Before Android QR Code Before Android Settings After Android QR Code After

Test plan

  • Tested locally on iOS
  • Tested locally on Android

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (57963fb) to head (399e35d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6226      +/-   ##
==========================================
- Coverage   88.93%   88.93%   -0.01%     
==========================================
  Files         737      737              
  Lines       31445    31446       +1     
  Branches     5828     5521     -307     
==========================================
  Hits        27966    27966              
- Misses       3279     3435     +156     
+ Partials      200       45     -155     
Files with missing lines Coverage Δ
src/qrcode/QRTabBar.tsx 79.62% <100.00%> (+0.38%) ⬆️

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57963fb...399e35d. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles are a bit strange; however, I was able to test by using grids and two browser windows with images of the same size. There's probably a better way to match these styles; however, the squeeze may not be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant