-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use react-native-quick-crypto #5865
Conversation
eb928e1
to
161cfee
Compare
c29b513
to
3ffb507
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5865 +/- ##
==========================================
- Coverage 87.64% 87.63% -0.01%
==========================================
Files 739 739
Lines 31837 31846 +9
Branches 5397 5702 +305
==========================================
+ Hits 27902 27907 +5
+ Misses 3891 3716 -175
- Partials 44 223 +179
... and 74 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
161cfee
to
8d7860f
Compare
3ffb507
to
4290d87
Compare
Description
Use https://github.com/margelo/react-native-quick-crypto to provide fast and secure crypto operations.
Note: We'll be able to gradually remove the following libs which are now redundant:
react-native-bip39
react-native-fast-crypto
react-native-securerandom
node-libs-react-native
and its own native deps (once ContractKit is removed)react-native-crypto
react-native-randombytes
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: