Update sentinel conf access string to allow hello channel access #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harkrishn Patro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #854 +/- ##
============================================
- Coverage 70.35% 70.22% -0.14%
============================================
Files 112 112
Lines 61467 61467
============================================
- Hits 43248 43164 -84
- Misses 18219 18303 +84 |
hpatro
changed the title
hwware
approved these changes
Jul 31, 2024
enjoy-binbin
approved these changes
Aug 3, 2024
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…key-io#854) This example of a minimal user account in your Valkey server for Sentinel is incorrect. If you add this ACL as-is to your valkey users.acl, valkey will add resetchannels -@ALL before the +client which prevents sentinel from publishing messages to the __sentinel__:hello pubsub for sentinel discovery. Fix valkey-io#744. Signed-off-by: Harkrishn Patro <[email protected]> Signed-off-by: mwish <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
This example of a minimal user account in your Valkey server for Sentinel is incorrect. If you add this ACL as-is to your valkey users.acl, valkey will add resetchannels -@ALL before the +client which prevents sentinel from publishing messages to the __sentinel__:hello pubsub for sentinel discovery. Fix #744. Signed-off-by: Harkrishn Patro <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
This example of a minimal user account in your Valkey server for Sentinel is incorrect. If you add this ACL as-is to your valkey users.acl, valkey will add resetchannels -@ALL before the +client which prevents sentinel from publishing messages to the __sentinel__:hello pubsub for sentinel discovery. Fix #744. Signed-off-by: Harkrishn Patro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example of a minimal user account in your Valkey server
for Sentinel is incorrect. If you add this ACL as-is to your
valkey users.acl, valkey will add resetchannels -@ALL before
the +client which prevents sentinel from publishing messages
to the sentinel:hello pubsub for sentinel discovery.
Fix #744.