Prepare for Valkey 8.0 RC1 release #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Xie <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
Co-authored-by: Binbin <[email protected]> Signed-off-by: Ping Xie <[email protected]>
hwware
reviewed
Jul 31, 2024
src/version.h
Outdated
| @@ -4,8 +4,8 @@ | |||
| * similar. */ | |||
| #define SERVER_NAME "valkey" | |||
| #define SERVER_TITLE "Valkey" | |||
| #define VALKEY_VERSION "255.255.255" | |||
| #define VALKEY_VERSION_NUM 0x00ffffff | |||
| #define VALKEY_VERSION "7.255.0" | |||
There was a problem hiding this comment.
In Redis, version 7.4-rc1 defines as
#define REDIS_VERSION "7.3.240"
#define REDIS_VERSION_NUM 0x000703f0
version 7.0-rc1 defines as
#define REDIS_VERSION "6.9.240"
#define REDIS_VERSION_NUM 0x000609f0
Thus, here I think we should define 8.0 RC1 as
#define VALKEY_VERSION "7.9.240"
#define VALKEY_VERSION_NUM 0x000709f0
There was a problem hiding this comment.
For some reason I thought we used 0 in the patch, I think 240 is fine.
madolson
reviewed
Jul 31, 2024
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #850 +/- ##
======================================
Coverage ? 70.21%
======================================
Files ? 112
Lines ? 61467
Branches ? 0
======================================
Hits ? 43159
Misses ? 18308
Partials ? 0 |
enjoy-binbin
reviewed
Aug 1, 2024
Signed-off-by: Ping Xie <[email protected]>
madolson
reviewed
Aug 1, 2024
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Ping Xie <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Ping Xie <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
Signed-off-by: Ping Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.