-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI concurrency #849
Fix CI concurrency #849
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, the ideas are great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! I didn't know about this. It's a little unfortunate that sometimes it's nice to submit a couple of sequential builds, but we can also tune it if we need to.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #849 +/- ##
============================================
- Coverage 70.35% 70.23% -0.13%
============================================
Files 112 112
Lines 61467 61467
============================================
- Hits 43248 43170 -78
- Misses 18219 18297 +78 |
Few CI improvements witch will reduce occupation CI queue and eliminate stale runs. 1. Kill CI jobs on PRs once PR branch gets a new push. This will prevent situation happened today - a huge job triggered twice in less than an hour and occupied all **org** (for all repositories) runners queue for the rest of the day (see pic). This completely blocked valkey-glide team. 2. Distribute nightly croned jobs on time to prevent them running together. Keep in mind, cron's TZ is UTC, so midnight tasks incur developers located in other timezones. This must be backported to all release branches (`valkey-x.y` and `x.y`) ![image](https://github.com/user-attachments/assets/923d8237-3cb7-42f5-80c8-5322b3f5187d) --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: mwish <[email protected]>
Few CI improvements witch will reduce occupation CI queue and eliminate stale runs. 1. Kill CI jobs on PRs once PR branch gets a new push. This will prevent situation happened today - a huge job triggered twice in less than an hour and occupied all **org** (for all repositories) runners queue for the rest of the day (see pic). This completely blocked valkey-glide team. 2. Distribute nightly croned jobs on time to prevent them running together. Keep in mind, cron's TZ is UTC, so midnight tasks incur developers located in other timezones. This must be backported to all release branches (`valkey-x.y` and `x.y`) ![image](https://github.com/user-attachments/assets/923d8237-3cb7-42f5-80c8-5322b3f5187d) --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Few CI improvements witch will reduce occupation CI queue and eliminate stale runs. 1. Kill CI jobs on PRs once PR branch gets a new push. This will prevent situation happened today - a huge job triggered twice in less than an hour and occupied all **org** (for all repositories) runners queue for the rest of the day (see pic). This completely blocked valkey-glide team. 2. Distribute nightly croned jobs on time to prevent them running together. Keep in mind, cron's TZ is UTC, so midnight tasks incur developers located in other timezones. This must be backported to all release branches (`valkey-x.y` and `x.y`) ![image](https://github.com/user-attachments/assets/923d8237-3cb7-42f5-80c8-5322b3f5187d) --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Few CI improvements witch will reduce occupation CI queue and eliminate stale runs.
This must be backported to all release branches (
valkey-x.y
andx.y
)