Improve reliability of dual-channel-replication pause resume tests #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: naglera <[email protected]>
ranshid
reviewed
Jul 28, 2024
| proc wait_and_resume_process idx { | ||
| set pid [srv $idx pid] | ||
| wait_for_log_messages $idx {"*Process is about to stop.*"} 0 2000 1 | ||
| exec kill -SIGCONT $pid |
There was a problem hiding this comment.
for the sake of modularity, can we call resume_process here instead (I know it is basically doing just that)
Signed-off-by: naglera <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #835 +/- ##
============================================
+ Coverage 70.20% 70.22% +0.01%
============================================
Files 112 112
Lines 61462 61462
============================================
+ Hits 43152 43164 +12
+ Misses 18310 18298 -12 |
ranshid
approved these changes
Jul 28, 2024
madolson
approved these changes
Jul 28, 2024
madolson
changed the title
|
Actually rethinking this is not a full protected against races since the print to log happen BEFORE the sigstop. Maybe we need to wait for process state to be 'T'? |
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…alkey-io#835) Update the dual channel-replication tests to wait for the pause to begin before attempting to unpause. --------- Signed-off-by: naglera <[email protected]> Signed-off-by: mwish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the dual channel-replication tests to wait for the pause to begin before attempting to unpause.