Fix unexpected behavior when turning appendonly on and off within a transaction #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction If we do `config set appendonly yes` and `config set appendonly no` in a multi, there are some unexpected behavior. When doing appendonly yes, we will schedule a AOFRW, and when we are doding appendonly no, we will call stopAppendOnly to stop it. In stopAppendOnly, the aof_fd is -1 since the aof is not start yet and the fsync and close will take the -1 and call it. Signed-off-by: Binbin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #826 +/- ##
============================================
+ Coverage 70.35% 70.38% +0.02%
============================================
Files 112 112
Lines 61310 61322 +12
============================================
+ Hits 43136 43160 +24
+ Misses 18174 18162 -12
|
zuiderkwast
reviewed
Jul 26, 2024
Signed-off-by: Binbin <[email protected]>
zuiderkwast
reviewed
Jul 26, 2024
zuiderkwast
approved these changes
Jul 26, 2024
Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: Binbin <[email protected]>
Merged
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…ransaction (valkey-io#826) If we do `config set appendonly yes` and `config set appendonly no` in a multi, there are some unexpected behavior. When doing appendonly yes, we will schedule a AOFRW, and when we are doding appendonly no, we will call stopAppendOnly to stop it. In stopAppendOnly, the aof_fd is -1 since the aof is not start yet and the fsync and close will take the -1 and call it, so they will all fail with EBADF. And stopAppendOnly will emit a server log, the close(-1) should be no problem but it is still an undefined behavior. This PR also adds a log `Background append only file rewriting scheduled.` to bgrewriteaofCommand when it was scheduled. And adds a log in stopAppendOnly when a scheduled AOF is canceled, it will print `AOF was disabled but there is a scheduled AOF background, cancel it.` Signed-off-by: Binbin <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: mwish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do
config set appendonly yesandconfig set appendonly noin a multi, there are some unexpected behavior.
When doing appendonly yes, we will schedule a AOFRW, and when we
are doding appendonly no, we will call stopAppendOnly to stop it.
In stopAppendOnly, the aof_fd is -1 since the aof is not start yet
and the fsync and close will take the -1 and call it, so they will
all fail with EBADF. And stopAppendOnly will emit a server log, the
close(-1) should be no problem but it is still an undefined behavior.
This PR also adds a log
Background append only file rewriting scheduled.to bgrewriteaofCommand when it was scheduled. And adds a log in
stopAppendOnly when a scheduled AOF is canceled, it will print
AOF was disabled but there is a scheduled AOF background, cancel it.