Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epoch information to failover auth denied logs #816

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

enjoy-binbin
Copy link
Member

When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.

When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin requested a review from PingXie July 23, 2024 11:57
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.32%. Comparing base (59aa008) to head (9e23d3a).
Report is 95 commits behind head on unstable.

Files with missing lines Patch % Lines
src/cluster_legacy.c 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #816      +/-   ##
============================================
+ Coverage     70.18%   70.32%   +0.13%     
============================================
  Files           112      112              
  Lines         61311    61311              
============================================
+ Hits          43031    43116      +85     
+ Misses        18280    18195      -85     
Files with missing lines Coverage Δ
src/cluster_legacy.c 85.59% <33.33%> (-0.07%) ⬇️

... and 12 files with indirect coverage changes

Signed-off-by: Binbin <[email protected]>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea.

@enjoy-binbin enjoy-binbin merged commit c7d1dae into valkey-io:unstable Aug 24, 2024
47 checks passed
@enjoy-binbin enjoy-binbin deleted the epoch_logs branch August 24, 2024 10:03
madolson pushed a commit that referenced this pull request Sep 2, 2024
When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.

Signed-off-by: Binbin <[email protected]>
madolson pushed a commit that referenced this pull request Sep 3, 2024
When failover deny to vote, sometimes due to network or
some blocking operations, the time of FAILOVER_AUTH_REQUEST
packet arrival is very uncertain. Since there is no epoch
information in these logs, it is hard to associate the log
with other logs.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin added the release-notes This issue should get a line item in the release notes label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes This issue should get a line item in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants