Update gitignore to ignore the cluster-cluster test files #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally we can create a test cluster directly in the directory using `./utils/create-cluster/create-cluster`, which would keep the test files under `./` and messed up the git. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #756 +/- ##
============================================
+ Coverage 70.13% 70.33% +0.19%
============================================
Files 111 111
Lines 60300 60300
============================================
+ Hits 42292 42410 +118
+ Misses 18008 17890 -118 |
madolson
approved these changes
Jul 9, 2024
Signed-off-by: Binbin <[email protected]>
zvi-code
pushed a commit
to zvi-code/valkey-z
that referenced
this pull request
Jul 14, 2024
) Normally we can create a test cluster directly in the directory using `./utils/create-cluster/create-cluster`, which would keep the test files under `./` and messed up the git. Signed-off-by: Binbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we can create a test cluster directly in the directory
using
./utils/create-cluster/create-cluster, which would keepthe test files under
./and messed up the git.