Copyright update to reflect IP transfer from Salvatore to Redis #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pieter Cailliau <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #740 +/- ##
============================================
+ Coverage 70.19% 70.31% +0.11%
============================================
Files 110 112 +2
Lines 60052 61492 +1440
============================================
+ Hits 42154 43236 +1082
- Misses 17898 18256 +358
|
|
Sorry for the delay, we were working on RC1. Will go through it today to double check the updates and then merge it. |
madolson
reviewed
Aug 6, 2024
| @@ -1,4 +1,4 @@ | |||
| Copyright (c) 2009-2011, Salvatore Sanfilippo <antirez at gmail dot com> | |||
| Copyright (c) 2009-2011, Redis Ltd. | |||
There was a problem hiding this comment.
FYI, this code was also vendored in hiredis, so will also be present in libvalkey https://github.com/valkey-io/libvalkey/blob/main/libvalkey/COPYING. Not sure if you also want to update that.
|
You also seem to have missed a couple, like valkey/tests/support/valkey.tcl Line 2 in 0fc43ed EDIT: Now noticing that thse had (C) instead of (c), might be a regex problem. |
madolson
reviewed
Aug 6, 2024
There was a problem hiding this comment.
I noticed you missed one reference to the copyright, so I took a deeper look and found a few more.
Just to list out all the Salvatore copyright references still present:
- utils/*: I assume you don't care about these
- COPYING: I assumed you omitted this one intentionally originally since it's sort of the main one that needs to be retained, but maybe it was missed.
- deps/linenoise/*: Seems missed, but maybe intentional.
- deps/lua/src/lua_cmsgpack: A bunch of references to Salvatore trademark in the msgpack code.
- src/(crc16.c,listpack.c,psqsort.c,setproctitle.c): These had a capital C in the copyright, so I'm guessing your regex just missed these.
- tests/support/(cluster.tcl,valkey.tcl): More capital Cs, so probably also missed.
|
@K-Jo Gentle ping if you still intend to update this. |
|
@madolson Thanks for your feedback. I pushed another commit to fix the issues you mentioned. |
Signed-off-by: Pieter Cailliau <[email protected]>
madolson
force-pushed
the
copyrightupdate
branch
from
cb3fda7 to
77d7e33
Compare
madolson
approved these changes
Aug 14, 2024
madolson
changed the title
madolson
changed the title
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 21, 2024
…ey-io#740) Update references of copyright being assigned to Salvatore when it was transferred to Redis Ltd. as per valkey-io#544. --------- Signed-off-by: Pieter Cailliau <[email protected]> Signed-off-by: mwish <[email protected]>
mapleFU
pushed a commit
to mapleFU/valkey
that referenced
this pull request
Aug 22, 2024
…ey-io#740) Update references of copyright being assigned to Salvatore when it was transferred to Redis Ltd. as per valkey-io#544. --------- Signed-off-by: Pieter Cailliau <[email protected]> Signed-off-by: mwish <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
Update references of copyright being assigned to Salvatore when it was transferred to Redis Ltd. as per #544. --------- Signed-off-by: Pieter Cailliau <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
Update references of copyright being assigned to Salvatore when it was transferred to Redis Ltd. as per #544. --------- Signed-off-by: Pieter Cailliau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update references of copyright being assigned to Salvatore when it was
transferred to Redis Ltd. as per #544.