Use 'primary' instead of 'master' in Sentinel tcl testing. #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #724 +/- ##
============================================
+ Coverage 70.23% 70.26% +0.02%
============================================
Files 111 111
Lines 60203 60305 +102
============================================
+ Hits 42286 42371 +85
- Misses 17917 17934 +17 |
hwware
reviewed
Jul 2, 2024
| @@ -64,7 +64,7 @@ test "SDOWN is triggered by crashed instance" { | |||
| ensure_master_up | |||
| } | |||
|
|
|||
| test "SDOWN is triggered by masters advertising as slaves" { | |||
| test "SDOWN is triggered by primarys advertising as slaves" { | |||
There was a problem hiding this comment.
Suggested change
| test "SDOWN is triggered by primarys advertising as slaves" { | |
| test "SDOWN is triggered by primaries advertising as slaves" { |
tests/sentinel/tests/00-base.tcl
Outdated
| @@ -56,7 +56,7 @@ test "SENTINEL PENDING-SCRIPTS returns the information about pending scripts" { | |||
| assert_morethan_equal [llength [S 0 SENTINEL PENDING-SCRIPTS]] 0 | |||
| } | |||
|
|
|||
| test "SENTINEL MASTERS returns a list of monitored masters" { | |||
| test "SENTINEL PRIMARYS returns a list of monitored primarys" { | |||
There was a problem hiding this comment.
Suggested change
| test "SENTINEL PRIMARYS returns a list of monitored primarys" { | |
| test "SENTINEL PRIMARIES returns a list of monitored primaries" { |
tests/sentinel/tests/00-base.tcl
Outdated
| assert {[RI $master_id role] eq {master}} | ||
| } | ||
|
|
||
| test "SENTINEL RESET can resets the master" { | ||
| test "SENTINEL RESET can resets the primary" { | ||
| # After SENTINEL RESET, sometimes the sentinel can sense the master again, |
There was a problem hiding this comment.
Suggested change
| # After SENTINEL RESET, sometimes the sentinel can sense the master again, | |
| # After SENTINEL RESET, sometimes the sentinel can sense the primary again, |
| @@ -63,7 +63,7 @@ proc wait_for_sentinels_connect_servers { {is_connect 1} } { | |||
| } | |||
| } | |||
|
|
|||
| test "Sentinels (re)connection following SENTINEL SET mymaster auth-pass" { | |||
| test "Sentinels (re)connection following SENTINEL SET myprimary auth-pass" { | |||
| # 3 types of sentinels to test: | |||
| # (re)started while master changed pwd. Manage to connect only after setting pwd | |||
There was a problem hiding this comment.
Suggested change
| # (re)started while master changed pwd. Manage to connect only after setting pwd | |
| # (re)started while primary changed pwd. Manage to connect only after setting pwd |
added 3 commits
July 3, 2024 09:48
Signed-off-by: z00808363 <[email protected]>
Signed-off-by: z00808363 <[email protected]>
Signed-off-by: z00808363 <[email protected]>
hwware
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'primary' instead of 'master' in Sentinel tcl testing.