Nested MULTI or WATCH in MULTI now will abort the transaction #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, for nested multi or executing watch in multi, we will return an error but we will not abort the transaction. ``` 127.0.0.1:6379> multi OK 127.0.0.1:6379(TX)> multi (error) ERR MULTI calls can not be nested127.0.0.1:6379(TX)> set key value QUEUED 127.0.0.1:6379(TX)> exec 1) OK 127.0.0.1:6379> multi OK 127.0.0.1:6379(TX)> watch key (error) ERR WATCH inside MULTI is not allowed 127.0.0.1:6379(TX)> set key value QUEUED 127.0.0.1:6379(TX)> exec 1) OK ``` In theory, this is also a syntax error, an unexpected behavior should abort the transaction. Add the NO_MULTI flag to them so that they will be rejected in processCommand and rejectCommand will abort the transaction. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
commented
Jul 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #723 +/- ##
============================================
- Coverage 70.25% 70.12% -0.14%
============================================
Files 111 111
Lines 60242 60236 -6
============================================
- Hits 42326 42240 -86
- Misses 17916 17996 +80
|
zuiderkwast
approved these changes
Jul 1, 2024
zuiderkwast
added
the
breaking-change
|
@madolson Let's merge it? @enjoy-binbin Can you edit the title to focus on the visible difference for the users? |
zuiderkwast
added
the
release-notes
|
I'm ok merging it. |
enjoy-binbin
changed the title
@zuiderkwast please take a look, you can fix it if necessary (i am not really good at it.) |
Hehe, it's good! 😄 |
zuiderkwast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for nested MULTI or executing WATCH in MULTI, we will return
an error but we will not abort the transaction.
This is an unexpected behavior that should abort the transaction.
The number of elements returned by EXEC also doesn't match the number
of commands in MULTI.
Add the NO_MULTI flag to them so that they will
be rejected in processCommand and rejectCommand will abort the transaction.
So there are two visible changes: