Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase ping and cluster timeout for cluster-slots test #717

Conversation

ranshid
Copy link
Member

@ranshid ranshid commented Jun 30, 2024

cluster-slots test is tesing a very fragmented slots range of a relatively large cluster. For this reason, when run under valgrind, some of the nodes are timing out when cluster is attempting to converge and propagate.
This pr sets the test's cluster-node-timeout to 90000 and cluster-ping-interval to 1000.

cluster-slots test is tesing a very fragmented slots range of a
relatively large cluster. For this reason, when run under valgrind,
some of the nodes are timing out when cluster is attempting to converge
and propagate.
This pr sets the test's cluster-node-timeout to 90000
and cluster-ping-interval to 1000.

Signed-off-by: ranshid <[email protected]>
@ranshid ranshid requested review from PingXie and hwware and removed request for PingXie June 30, 2024 17:06
Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ranshid!

@PingXie PingXie merged commit 2420881 into valkey-io:unstable Jun 30, 2024
16 checks passed
@hwware
Copy link
Member

hwware commented Jul 1, 2024

Thanks @ranshid hard work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants