Update redis keyword to valkey in some sentinel functions (Redis Legacy) #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #706 +/- ##
============================================
- Coverage 70.28% 70.08% -0.20%
============================================
Files 111 111
Lines 60299 60299
============================================
- Hits 42381 42262 -119
- Misses 17918 18037 +119
|
zuiderkwast
approved these changes
Jun 27, 2024
src/sentinel.c
Outdated
| int quorum, | ||
| sentinelRedisInstance *primary) { | ||
| sentinelRedisInstance *ri; | ||
| sentinelValkeyInstance *createSentinelRedisInstance(char *name, |
There was a problem hiding this comment.
Function name is still createSentinelRedisInstance. Change this too?
src/sentinel.c
Outdated
| @@ -1350,7 +1349,7 @@ sentinelRedisInstance *createSentinelRedisInstance(char *name, | |||
| * This function does not take care of unlinking the instance from the main | |||
| * primaries table (if it is a primary) or from its primary sentinels/replicas table | |||
| * if it is a replica or sentinel. */ | |||
| void releaseSentinelRedisInstance(sentinelRedisInstance *ri) { | |||
| void releaseSentinelRedisInstance(sentinelValkeyInstance *ri) { | |||
There was a problem hiding this comment.
Function name still contains redis.
src/sentinel.c
Outdated
| @@ -1448,10 +1447,10 @@ int removeMatchingSentinelFromPrimary(sentinelRedisInstance *primary, char *runi | |||
| * | |||
| * runid or addr can be NULL. In such a case the search is performed only | |||
| * by the non-NULL field. */ | |||
| sentinelRedisInstance *getSentinelRedisInstanceByAddrAndRunID(dict *instances, char *addr, int port, char *runid) { | |||
| sentinelValkeyInstance *getSentinelRedisInstanceByAddrAndRunID(dict *instances, char *addr, int port, char *runid) { | |||
There was a problem hiding this comment.
Function name contains redis.
There was a problem hiding this comment.
https://github.com/valkey-io/valkey/blob/5925cc7c4fdd89e9547fa2602d5e46213c70f891/src/sentinel.c
i see there are still some places are using the Redis word, can you do a search and also fix it? like addReplySentinelRedisInstance
hwware
force-pushed
the
update-redis-in-sentinel
branch
3 times, most recently
from
b9ae8bb to
f9b9713
Compare
zuiderkwast
approved these changes
Jul 4, 2024
Signed-off-by: hwware <[email protected]>
Signed-off-by: hwware <[email protected]>
Signed-off-by: hwware <[email protected]>
hwware
force-pushed
the
update-redis-in-sentinel
branch
from
f9b9713 to
d1e9cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all Redis/redis keywords to Valkey/valkey, including variable names, comments, function names.
All sentinel test cases passed.