-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very minor misspelling in some tests #705
Very minor misspelling in some tests #705
Conversation
the updated typo only for the test case name, should not be reason cause test cases failure BTW. DCO pls sign off. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #705 +/- ##
============================================
- Coverage 70.22% 70.07% -0.15%
============================================
Files 110 111 +1
Lines 60108 60213 +105
============================================
- Hits 42213 42197 -16
- Misses 17895 18016 +121 |
My apologies; I wasn't implying that the misspellings caused the tests to fail; I simply noticed the misspellings because these tests had failed during a build. |
No worries. As wen mentioned though, we require a DCO to submit code. You can read more about it here: https://github.com/valkey-io/valkey/blob/unstable/CONTRIBUTING.md#developer-certificate-of-origin. You can see one of the checks failing. You'll need to sign it and git force push over your change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fix the DCO. If you click on Details near the failed CI job ❌ DCO, you can find some help how to fix it.
bc56e2c
to
d8e4851
Compare
Signed-off-by: w. ian douglas <[email protected]>
d8e4851
to
9b33246
Compare
fixed |
Fix misspelling "faiover" instead of "failover" in two test cases.