Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor misspelling in some tests #705

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

iandouglas
Copy link
Contributor

@iandouglas iandouglas commented Jun 27, 2024

Fix misspelling "faiover" instead of "failover" in two test cases.

@hwware
Copy link
Member

hwware commented Jun 27, 2024

the updated typo only for the test case name, should not be reason cause test cases failure

BTW. DCO pls sign off.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.07%. Comparing base (28c5a17) to head (9b33246).
Report is 8 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #705      +/-   ##
============================================
- Coverage     70.22%   70.07%   -0.15%     
============================================
  Files           110      111       +1     
  Lines         60108    60213     +105     
============================================
- Hits          42213    42197      -16     
- Misses        17895    18016     +121     

see 18 files with indirect coverage changes

@iandouglas
Copy link
Contributor Author

My apologies; I wasn't implying that the misspellings caused the tests to fail; I simply noticed the misspellings because these tests had failed during a build.

@madolson
Copy link
Member

My apologies; I wasn't implying that the misspellings caused the tests to fail; I simply noticed the misspellings because these tests had failed during a build.

No worries. As wen mentioned though, we require a DCO to submit code. You can read more about it here: https://github.com/valkey-io/valkey/blob/unstable/CONTRIBUTING.md#developer-certificate-of-origin. You can see one of the checks failing. You'll need to sign it and git force push over your change.

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please fix the DCO. If you click on Details near the failed CI job ❌ DCO, you can find some help how to fix it.

@zuiderkwast zuiderkwast added the polish typos, style, etc label Jun 27, 2024
@madolson madolson added the pending-missing-dco For PRs that are blocked because they are missing a dco label Jun 27, 2024
@iandouglas iandouglas force-pushed the misspellings-in-tests branch 2 times, most recently from bc56e2c to d8e4851 Compare June 28, 2024 20:12
@iandouglas iandouglas force-pushed the misspellings-in-tests branch from d8e4851 to 9b33246 Compare June 28, 2024 20:13
@iandouglas
Copy link
Contributor Author

fixed

@zuiderkwast zuiderkwast merged commit b59762f into valkey-io:unstable Jun 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-missing-dco For PRs that are blocked because they are missing a dco polish typos, style, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants