Allow Module blocking operations (not blocked on keys) to succeed when cluster is down #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarthikSubbarao
changed the title
KarthikSubbarao
changed the title
Signed-off-by: KarthikSubbarao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #693 +/- ##
============================================
- Coverage 70.20% 70.08% -0.13%
============================================
Files 111 110 -1
Lines 60242 60102 -140
============================================
- Hits 42295 42122 -173
- Misses 17947 17980 +33
|
Signed-off-by: KarthikSubbarao <[email protected]>
zuiderkwast
reviewed
Jun 25, 2024
Signed-off-by: KarthikSubbarao <[email protected]>
hpatro
approved these changes
Jun 25, 2024
zuiderkwast
reviewed
Jun 25, 2024
Signed-off-by: KarthikSubbarao <[email protected]>
…down errors Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
madolson
added
the
release-notes
madolson
approved these changes
Jul 1, 2024
KarthikSubbarao
changed the title
|
Thank you - I updated the PR title and description because we made this fix generic to Module blocking operations (which are not blocked on keys) |
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Jul 8, 2024
…o#693) Module Authentication using a blocking implementation currently gets rejected when the "cluster is down" from the client timeout cron job (`clientsCronHandleTimeout`). This PR exempts clients blocked on Module Authentication from being rejected here. --------- Signed-off-by: KarthikSubbarao <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Jul 9, 2024
…o#693) Module Authentication using a blocking implementation currently gets rejected when the "cluster is down" from the client timeout cron job (`clientsCronHandleTimeout`). This PR exempts clients blocked on Module Authentication from being rejected here. --------- Signed-off-by: KarthikSubbarao <[email protected]>
PingXie
pushed a commit
to PingXie/valkey
that referenced
this pull request
Jul 9, 2024
…o#693) Module Authentication using a blocking implementation currently gets rejected when the "cluster is down" from the client timeout cron job (`clientsCronHandleTimeout`). This PR exempts clients blocked on Module Authentication from being rejected here. --------- Signed-off-by: KarthikSubbarao <[email protected]> Signed-off-by: Ping Xie <[email protected]>
PingXie
pushed a commit
that referenced
this pull request
Jul 10, 2024
Module Authentication using a blocking implementation currently gets rejected when the "cluster is down" from the client timeout cron job (`clientsCronHandleTimeout`). This PR exempts clients blocked on Module Authentication from being rejected here. --------- Signed-off-by: KarthikSubbarao <[email protected]> Signed-off-by: Ping Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing a fix for this issue - #619 - and adding tests.
Module blocking operations (which are not blocked on keys) currently gets rejected when the "cluster is down" from the client timeout cron job (
clientsCronHandleTimeout). Example: Module Authentication with a blocking implementation.This PR exempts clients blocked by a Module (but not on keys) from being rejected here on a failed cluster state.