-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing REDIS_STATIC with static #691
Conversation
@ouriamzn can you please fix the DCO? It looks like the commit is incorrectly signed off. |
That's nothing I've heard about. Who discussed this, when and where? |
@zuiderkwast Previous PR: #684 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM
I think fix the top comment so that this PR stand by itself.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #691 +/- ##
============================================
+ Coverage 70.05% 70.26% +0.20%
============================================
Files 110 110
Lines 60084 60104 +20
============================================
+ Hits 42094 42231 +137
+ Misses 17990 17873 -117
|
Signed-off-by: Ouri Half <[email protected]>
Signed-off-by: Ouri Half <[email protected]>
As discussed, we want to remove the old
REDIS_STATIC
flag which is no longer relevant.When moving from Redis to Valkey we renamed all REDIS flags in Makefile.
The REDIS_STATIC flag was renamed to SERVER_STATIC, but this change was not updated in some of the files.
After discussing it with @madolson and @ranshid, we decided that since this was introduced 10 years ago, and in many places in the code base we simply use
static
, we should simplify and remove the flag entirely.