Improve CLUSTER SETSLOT replication handling to support older replica versions.
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid restarting Valkey server during the test. The `DEBUG RESTART` procedure was not always reliable, as sometimes the server would fail to restart, leading to flaky tests. Signed-off-by: Ping Xie <[email protected]>
…ca versions. Added logic to iterate through the list of replicas and check for any replicas running a version older than 8.0.0. Older replicas do not support the CLUSTER SETSLOT command on replicas. If such a replica is found, the replication is skipped and falls back to the old (non-replicated) behavior. Signed-off-by: Ping Xie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #686 +/- ##
============================================
+ Coverage 70.05% 70.20% +0.14%
============================================
Files 110 110
Lines 60084 60092 +8
============================================
+ Hits 42094 42189 +95
+ Misses 17990 17903 -87
|
enjoy-binbin
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to iterate through the list of replicas and check for any replicas running a version older than 8.0.0. Older replicas do not support the CLUSTER SETSLOT command on replicas. If such a replica is found, the replication is skipped and falls back to the old (non-replicated) behavior.
Fix #421