Introduce log.h to decouple serverLog from server.h. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #664 +/- ##
============================================
- Coverage 70.20% 70.20% -0.01%
============================================
Files 110 111 +1
Lines 60078 60071 -7
============================================
- Hits 42179 42172 -7
Misses 17899 17899
|
Signed-off-by: Lipeng Zhu <[email protected]>
Signed-off-by: Lipeng Zhu <[email protected]>
madolson
reviewed
Jun 18, 2024
|
|
||
| #define serverLogRaw(level, ...) \ | ||
| do { \ | ||
| if (((level) & 0xff) < server.verbosity) break; \ |
There was a problem hiding this comment.
Suggested change
| if (((level) & 0xff) < server.verbosity) break; \ | |
| if (((level) & 0xff) < server.verbosity) break; \ |
This feels a bit like fake decoupling, since you can't import log.h without server.h, since we are accessing the server structure here.
There was a problem hiding this comment.
Yeah, the existing log implementation seems relied server and server config too much, its not straightforward to split it from server.h. Let's open an issue to discuss the code refactor work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #599 (comment)